-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2.2] Cirrus: Skip frequent flake on v2.2 branch #9600
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cevich The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is #7340. Unfortunately, your |
For the last three days, it's consistently hit this one exact test on Fedora or Ubuntu. Whatever the cause is, we just want it to stop 😁 @edsantiago Do you think it would help to backport any/all of the "fix" PRs (mentioned in that issue) to this branch? |
That's a risk evaluation I have no idea how to make: I don't know what this branch is used for, nor how important it is, nor how difficult it would be to backport #7561 and #7574.
Oh, understood, and I'm fine with that. I should've been more clear: this PR will not fix anything. It will be whack-a-mole. It may silence the error in one particular test, but the error will recur (in integration tests too). I was just trying to offer a heads-up. I would've lgtm'ed this morning, but tests were red. I would lgtm right now, but tests are still red. |
If you need to ask...it's probably not worth the risk. We can keep this in mind if it does turn out to be wack-a-mole.
I wanted to check with you first before spending time investigating that. No idea why they all failed. |
This test frequently flakes on at least one platform during daily cirrus-cron runs on the v2.2 branch. Since this is not happening on other versions, assume it's some kind of difficult-to-find/fix race condition. Skip the test on all platforms to cut down on noise. Ref: containers#7340 Signed-off-by: Chris Evich <[email protected]>
1ed85ed
to
7d16e06
Compare
Closing in favor of #9664 |
Derpends on: #9620
This test frequently flakes on at least one platform during daily
cirrus-cron runs on the v2.2 branch. Since this is not happening on
other versions, assume it's some kind of difficult-to-find/fix race
condition. Skip the test on all platforms to cut down on noise.
Example: https://cirrus-ci.com/task/4715979050582016?command=main#L75
(Same failure observed on Ubuntu as well)